This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Default FileExporter file_mode to a #887
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current default,
w+, overwrites the contents of the file on the first write. Sinceemitopens and writes to the file every time it's called, this effectively rewrites the file on everyemit. Perhaps this is intended behavior, but it took me a while to understand why there was only one span written to my file, even though I could tell multiple were being emitted. I didn't have my Python file mode tables memorized, so at first glancew+sounded like "write mode, + for append", and I overlooked it while debugging.I think
a(append) would be a more intuitive default.