fix(renderer): remove carriage returns from frames #1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that carriage return characters are stripped from the output frames before rendering. This prevents potential rendering issues that can arise from the presence of carriage returns, which may interfere with the correct display of the frame content. Fixes: #1520
aymanbagabas
requested review from
a team,
andreynering and
tauraamui
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 69.46% 69.49% +0.02%
==========================================
Files 17 17
Lines 1320 1321 +1
==========================================
+ Hits 917 918 +1
Misses 350 350
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreynering
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that carriage return characters are stripped from the output frames before rendering. This prevents potential rendering issues that can arise from the presence of carriage returns, which may interfere with the correct display of the frame content.
Fixes: #1520