Support CRIU 4.2 CLI arguments, upgrade package version #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Bumping to v8 seems unnecessary as we do not break API. At least from my point of view. |
Mitiaj
force-pushed
the
feat/support-criu-v4
branch
2 times, most recently
from
65ca398 to
6343237
Compare
Member
|
Much better diff 😉 |
rst0git
reviewed
Nov 25, 2025
rpc/rpc.proto
Outdated
| optional bool stream = 73; | ||
| optional bool ghost_fiemap = 74; | ||
| optional criu_file_validation_method file_validation_method = 75 [default = BUILD_ID]; | ||
| optional bool deprecated_ok = 76; |
Member
There was a problem hiding this comment.
Hmm, these fields are not in CRIU's rpc.proto file:
https://github.com/checkpoint-restore/criu/blob/master/images/rpc.proto
Adding them here would not make any difference because CRIU will not support them.
Member
There was a problem hiding this comment.
There is an open PR for the stream field (checkpoint-restore/criu#2536).
Adding these fields to the rpc.proto file also requires changes in CRIU.
Author
There was a problem hiding this comment.
makes sense. let me remove these options
Downgrade package version to v7 Signed-off-by: Michal Voitiulevic <[email protected]>
Mitiaj
force-pushed
the
feat/support-criu-v4
branch
from
6343237 to
4d24d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.