feat: more link inspection support #1896
Conversation
secDre4mer
force-pushed
the
feat/add-link-info-types
branch
2 times, most recently
from
26a871d to
9b0dcdd
Compare
mmat11
left a comment
mmat11
left a comment
There was a problem hiding this comment.
looks mostly good to me, left a few comments; can this be split in multiple commits?
| if umi.offsets == nil { | ||
| return nil, fmt.Errorf("no offsets available") | ||
| } | ||
| ex, err := OpenExecutable(umi.path) |
There was a problem hiding this comment.
hmm I wonder if this is safe to do; should we just return addresses like for kprobeMulti?
There was a problem hiding this comment.
I'm not sure, that's why there are the different Offsets and Symbols functions. Offsets returns the raw offsets, and only Symbols tries to resolve them.
Sure, I'll try. Any ideas on how the commits should be structured? E.g. one focused on uprobe, one focused on tracepoint, ...? |
I guess you could split code generation and the different link types in different commits |
secDre4mer
force-pushed
the
feat/add-link-info-types
branch
from
9b0dcdd to
d0b8794
Compare
Signed-off-by: Max Altgelt <[email protected]>
Signed-off-by: Max Altgelt <[email protected]>
Signed-off-by: Max Altgelt <[email protected]>
Signed-off-by: Max Altgelt <[email protected]>
The netfilter options / info required / contained protocol family and hook, with little information for the user what values were expected. Add explicit types with constants to clarify what values are supported. Signed-off-by: Max Altgelt <[email protected]>
Signed-off-by: Max Altgelt <[email protected]>
Signed-off-by: Max Altgelt <[email protected]>
Signed-off-by: Max Altgelt <[email protected]>
secDre4mer
force-pushed
the
feat/add-link-info-types
branch
from
d0b8794 to
5f0a645
Compare
|
Split is done. |
2 participants
Add support for more link inspection types, e.g. to query a uprobe's symbol.