Fix not working link toolbar on iOS. #18071
Draft
+436
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tested on my device, imho good enough fix for now, clicking at the end of the link still works, clicking on the link shows toolbar, and Apple native selection handler, but this one is easily discardable with a second tap. |
niegowski
reviewed
Mar 10, 2025
niegowski
reviewed
Mar 17, 2025
| if ( isLinkElement( targetViewElement ) ) { | ||
| linkElement = targetViewElement; | ||
| } else { | ||
| linkElement = targetViewElement.getAncestors().find( isLinkElement ) as ViewElement | null; |
Contributor
There was a problem hiding this comment.
This should be an abstract 2scm element, not a link specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (link): Fix not working link toolbar on iOS. Closes #18023
Additional information
Before
ios-linking-experience-problem-2025-03-03_13.33.12.mp4
After
ios-linking-experience-problem-v2-2025-03-03_13.51.22.mp4