Skip to content

Conversation

@ang-cloudflare
Copy link

@ang-cloudflare ang-cloudflare commented Nov 11, 2025

  • Add TestAccCloudflareUniversalSSLSetting_Basic with create, update, and import steps
  • Validates resource adoption with enabled = true
  • Validates update to enabled = false
  • Validates terraform import functionality with ImportStateVerify
  • Add testdata template for universal SSL setting configuration

Tests validated locally by cherry-picking zero_trust_dex_test fixes (commits 1ac3faa + missing customfield import).

All tests pass successfully:

=== RUN   TestAccCloudflareUniversalSSLSetting_Basic
--- PASS: TestAccCloudflareUniversalSSLSetting_Basic (10.65s)
PASS
  • I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Acceptance test run results

  • I have run acceptance tests for my changes and included the results below
=== RUN   TestAccCloudflareUniversalSSLSetting_Basic
--- PASS: TestAccCloudflareUniversalSSLSetting_Basic (10.65s)
PASS

Additional context & links

- Add TestAccCloudflareUniversalSSLSetting_Basic with create, update, and import steps
- Validates resource adoption with enabled = true
- Validates update to enabled = false
- Validates terraform import functionality with ImportStateVerify
- Add testdata template for universal SSL setting configuration

Tests validated locally by cherry-picking zero_trust_dex_test fixes
(commits 1ac3faa + missing customfield import).

All tests pass successfully:
=== RUN   TestAccCloudflareUniversalSSLSetting_Basic
--- PASS: TestAccCloudflareUniversalSSLSetting_Basic (10.65s)
PASS
@musa-cf
Copy link
Contributor

musa-cf commented Nov 12, 2025

Just checking, is this a duplicate of #6434? Does that one need to be merged first, or can it be closed?

@vaishakdinesh
Copy link
Member

Just checking, is this a duplicate of #6434? Does that one need to be merged first, or can it be closed?

Yup. That's case.

@musa-cf musa-cf merged commit d1b24b7 into cloudflare:next Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants