Skip to content

Conversation

@ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Nov 18, 2025

When running autoconfig in a SvelteKit site, we install wrangler, which cases the repo to be dirty. This then causes sv add to hang waiting for approval to deploy with uncommitted changes. This PR passes the --no-git-check flag to ensure it installs correctly.


  • Tests
    • Tests included
    • Tests not necessary because: the basic C3 e2e SvelteKit flow is already tested (added in Support SvelteKit in autoconfig #11268), C3 e2es currently don't have a setup for testing git related aspect so there is currently no clear way to reproduce there the bug being fixed here
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not in v3

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: ddcc21f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Nov 18, 2025
@ascorbic ascorbic added the skip-v3-pr Skip validation of presence of a v3 backport PR label Nov 18, 2025
@ascorbic ascorbic marked this pull request as ready for review November 18, 2025 16:27
@ascorbic ascorbic requested a review from a team as a code owner November 18, 2025 16:27
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11328

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11328

miniflare

npm i https://pkg.pr.new/miniflare@11328

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11328

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11328

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11328

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11328

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11328

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11328

wrangler

npm i https://pkg.pr.new/wrangler@11328

commit: ddcc21f

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI concurs

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 18, 2025
@ascorbic ascorbic merged commit bb44120 into main Nov 20, 2025
34 of 35 checks passed
@ascorbic ascorbic deleted the mk/wrangler/sv-git-check branch November 20, 2025 13:23
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants