Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Nov 20, 2025

The native implementation is available since cloudflare/workerd#5031
It is a superset of the unenv implementation.

/cc @anonrig @jasnell


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: documented by the runtime team
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: unenv changes are not backported

@vicb vicb requested review from a team as code owners November 20, 2025 08:01
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: 4770579

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/unenv-domain might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11353
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11353

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11353

miniflare

npm i https://pkg.pr.new/miniflare@11353

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11353

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11353

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11353

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11353

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11353

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11353

wrangler

npm i https://pkg.pr.new/wrangler@11353

commit: 4770579

@vicb vicb added the skip-v3-pr Skip validation of presence of a v3 backport PR label Nov 20, 2025
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked how the workerd implementation compares to unenv... Most methods are equivalent noops. The bind, intercept and run methods used to throw in unenv but now just return the callback with no side-effects.

The one potential breaking change is that the members property in unenv is initialized to [] but is undefined in workerd. But this is what Node.js does itself so we are good there.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 20, 2025
@vicb vicb merged commit 0cf696d into main Nov 20, 2025
34 of 35 checks passed
@vicb vicb deleted the vicb/unenv-domain branch November 20, 2025 10:40
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants