Skip to content

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Jan 28, 2025

Fixes #7791.

This PR un-reverts #7791 which was made because of a bug upstream and is now fixed in #7793. We should verify it on the preview playground before merging this PR. I have tested this on the preview environment as described on this comment.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Tested manually
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Tested manually.
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@edmundhung edmundhung requested a review from a team as a code owner January 28, 2025 14:57
@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 4dabeff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
workers-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung edmundhung changed the title fix(workers-playground): opt-in raw request method through the X-CF-HTTP-Method header fix(workers-playground): send raw request method through the X-CF-HTTP-Method header Jan 28, 2025
@edmundhung edmundhung force-pushed the revert-7791-revert-7639-edmundhung/DEVX-1449-playground-raw-request-method-update branch from 9c2c45c to 6262d9e Compare January 28, 2025 16:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-wrangler-7936

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7936/npm-package-wrangler-7936

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-wrangler-7936 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workers-bindings-extension-7936 -O ./cloudflare-workers-bindings-extension.0.0.0-v7644f69bf.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7644f69bf.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-create-cloudflare-7936 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-kv-asset-handler-7936

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-miniflare-7936

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-pages-shared-7936

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-unenv-preset-7936

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-vite-plugin-7936

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-vitest-pool-workers-7936

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workers-editor-shared-7936

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workers-shared-7936

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workflows-shared-7936

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250124.0
workerd 1.20250124.0 1.20250124.0
workerd --version 1.20250124.0 2025-01-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the revert-7791-revert-7639-edmundhung/DEVX-1449-playground-raw-request-method-update branch from ddc971b to 4dabeff Compare January 29, 2025 11:54
@edmundhung edmundhung added the preview:workers-playground Trigger a workers playground preview deploy label Jan 29, 2025
@edmundhung
Copy link
Member Author

Here is what I have done to verify this change:

  1. Deploying the changes to the preview playground using the preview:workers-playground label. You can find the preview playground link from the CI log.

  2. To test this, I have updated the worker script with the following code:

export default {
  async fetch(request, env, ctx) {
    return new Response(request.method, {
      headers: {
        "request-method": request.method,
      },
    });
  },
};

You can also visit this link with the code updated.

  1. Make some requests on the HTTP tab with different methods. This reason of this changes is to fix OPTIONS request. But we introduced another bug on GET / HEAD method while fixing this. We expect all the requests to the preview worker to response with the request method (except for HEAD request which will never include a body, but we can verify it with the request-method header.

@edmundhung edmundhung merged commit 2a59eae into main Jan 31, 2025
33 of 34 checks passed
@edmundhung edmundhung deleted the revert-7791-revert-7639-edmundhung/DEVX-1449-playground-raw-request-method-update branch January 31, 2025 12:34
@lrapoport-cf
Copy link
Contributor

for posterity, confirming @penalosa tested manually as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:workers-playground Trigger a workers playground preview deploy

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants