-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(workers-playground): send raw request method through the X-CF-HTTP-Method header
#7936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workers-playground): send raw request method through the X-CF-HTTP-Method header
#7936
Conversation
🦋 Changeset detectedLatest commit: 4dabeff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
X-CF-HTTP-Method headerX-CF-HTTP-Method header
9c2c45c to
6262d9e
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-wrangler-7936You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7936/npm-package-wrangler-7936Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-wrangler-7936 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workers-bindings-extension-7936 -O ./cloudflare-workers-bindings-extension.0.0.0-v7644f69bf.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7644f69bf.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-create-cloudflare-7936 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-kv-asset-handler-7936miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-miniflare-7936@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-pages-shared-7936@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-unenv-preset-7936@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-vite-plugin-7936@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-vitest-pool-workers-7936@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workers-editor-shared-7936@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workers-shared-7936@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13030746097/npm-package-cloudflare-workflows-shared-7936Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
…ough the…" This reverts commit f8c11d7.
ddc971b to
4dabeff
Compare
|
Here is what I have done to verify this change:
export default {
async fetch(request, env, ctx) {
return new Response(request.method, {
headers: {
"request-method": request.method,
},
});
},
};You can also visit this link with the code updated.
|
|
for posterity, confirming @penalosa tested manually as well |
Fixes #7791.
This PR un-reverts #7791 which was made because of a bug upstream and is now fixed in #7793.
We should verify it on the preview playground before merging this PR.I have tested this on the preview environment as described on this comment.