-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for Images binding #7945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c9b3704 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* Add Images binding * Add Images remote preview mode * Plumb images local mode flag through * Add Images binding local mode * Add Images E2E test * Hoist @img packages This fixes the fixture tests, perhaps because sharp does something unusual with imports, see GH comment: nuxt/image#1210 (comment) * Add local suffix when printing bindings * Swap describe/it in E2E test * Mark sharp as unbundled, rather than hoisting * Remove zod * Improve error messages
268bd5a to
c9b3704
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-wrangler-7945You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7945/npm-package-wrangler-7945Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-wrangler-7945 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-workers-bindings-extension-7945 -O ./cloudflare-workers-bindings-extension.0.0.0-v00d1b781f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v00d1b781f.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-create-cloudflare-7945 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-kv-asset-handler-7945miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-miniflare-7945@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-pages-shared-7945@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-unenv-preset-7945@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-vite-plugin-7945@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-vitest-pool-workers-7945@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-workers-editor-shared-7945@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-workers-shared-7945@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13017076509/npm-package-cloudflare-workflows-shared-7945Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
This reverts commit d758215.
Fixes #7882.
This was previously merged in #7424 but have to be reverted in #7882 because of missing permission running the e2e tests. This is now resolved and is confirmed on #7958.