fix: embed root cause errors in returned errors #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aauren
force-pushed
the
fix_missing_error_embed
branch
from
269bbd2 to
8c9d25f
Compare
mrueg
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always embed the root cause error on returned errors so that the root cause can be determined.
Fixes #1962
FYI @zerkms
As an aside, I'm pretty sure that there are other places in the code besides node.go that drop the root cause errors, but I want to wait until we merge @catherinetcai's PR #1914 to get merged before I go through and clean up error handling across the entire code base as it will just cause a bunch or refactoring work if I do it now.