Support listing volumes #1959
Open
Support listing volumes #1959
+214
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import ContainerHeader from './ContainerHeader.jsx'; | ||
| import Containers from './Containers.jsx'; | ||
| import Images from './Images.jsx'; | ||
| import { Volume } from './Volume.jsx'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Member
|
I like this, thanks! Another idea I have is to show which containers use the volume. Maybe a popover for the text in the "Used by" column? |
Member
Author
Right we have this for images!
So maybe an expandable makes sense here. |
Contributor
|
@jelly this would be a great addition to cockpit-podman, is there anything left to do before merging this PR? I'd be willing to help with implementing the display of the size of the volumes later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rought mockup with basic volume listing
Let's add a basic listing and then
Related to: #2342