-
Notifications
You must be signed in to change notification settings - Fork 21
Fully qualify references to generated interfaces #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fully qualify references to generated interfaces #89
Conversation
AutomaticInterface/AutomaticInterface/AutomaticInterfaceGenerator.cs
Outdated
Show resolved
Hide resolved
011fcc7 to
332a2db
Compare
f449545 to
dfcb5b7
Compare
dfcb5b7 to
28df788
Compare
|
This is ready for review again - I just had a last minute refactoring idea :) |
|
Could you be so kind and merge master into this? Than I will merge it as 6.x I think because it's potentially breaking |
|
Not a problem @ChristianSauer. I hope to get this done next week. |
28df788 to
12ad491
Compare
|
Hi @ChristianSauer, I've rebased the branch on master, but happy to get the other PR merged first, then I can rebase and refactor again, as I think I should probably move the other PR's changes into the |
12ad491 to
7302977
Compare
5d8726b to
4cce479
Compare
|
@simonmckenzie I merged the other PR first :) |
This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names _where a single unambiguous match can be made between the symbol and the list of interfaces being generated_.
- Change approach to use `ToDisplayParts`, which removes the need for regex parsing of generated code - Fix bug in `ReplaceWithInferredInterfaceName` where dots weren't being escaped - Add tests to ensure partially qualified references will be resolved correctly
…class; refactor This centralises the rendering logic plus simplifies the implementation to use `ITypeSymbol.WithNullableAnnotation` and hands the rendering off to the default `ToDisplayString` implementation
4cce479 to
9148e56
Compare
|
Hi @ChristianSauer, I've rebased again and refactored the changes from #85 into the |
This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. See #87.
The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names where a single unambiguous match can be made between the symbol and the list of interfaces being generated.
For the example provided in #87, the code will now generate this output: