Skip to content

Conversation

@matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Apr 4, 2025

needed for codecov/umbrella#30

previously i added working_directory to these workflows so that umbrella could make each one run cd apps/worker or similar at the beginning. it turns out, however, that we need to build requirements images in the umbrella root rather than apps/worker etc. so this PR replaces working_directory with a new make_target_prefix argument: if the workflow ordinarily calls make build, umbrella can use this argument to make it call make worker.build

unfortunately, i couldn't completely get rid of the old working_directory. with the way things are set up, things like app.tar or junit.xml are still dumped in apps/worker. so i renamed the argument output_directory to match its new function

finally, this PR adds the reqs_cache_key argument to build-app.yml and self-hosted.yml. this allows umbrella to pass in a special cache key for its special requirements images which include an extra hash. if the argument isn't provided, the cache key is computed like normal.

@matt-codecov matt-codecov force-pushed the matt/make-target-prefix branch 3 times, most recently from 89f35a0 to 8d4e36b Compare April 4, 2025 23:45
@matt-codecov matt-codecov force-pushed the matt/make-target-prefix branch from 8d4e36b to fb85617 Compare April 4, 2025 23:53
@matt-codecov matt-codecov requested a review from a team April 8, 2025 00:06
@matt-codecov matt-codecov marked this pull request as ready for review April 8, 2025 00:06
@matt-codecov matt-codecov merged commit 5d811d6 into main Apr 8, 2025
1 check passed
@matt-codecov matt-codecov deleted the matt/make-target-prefix branch April 8, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants