Skip to content

Conversation

@comfyanonymous
Copy link
Owner

@comfyanonymous comfyanonymous commented Dec 7, 2025

There is still one of the text encoders missing and I didn't actually test it.

This might be enough to let you run the model using their custom nodes.

There is still one of the text encoders missing and I didn't actually test
it.
@comfyanonymous comfyanonymous merged commit 56fa7db into master Dec 7, 2025
12 checks passed
@comfyanonymous comfyanonymous deleted the temp_pr branch December 7, 2025 12:45
@nestflow
Copy link

nestflow commented Dec 7, 2025

The clip part does not work with their custom node for now:

  File "D:\Projects\ComfyUI\comfy\samplers.py", line 705, in encode_model_conds
    out = model_function(**params)
  File "D:\Projects\ComfyUI\comfy\model_base.py", line 1113, in extra_conds
    clip_text_pooled = kwargs["pooled_output"]  # Newbie
                       ~~~~~~^^^^^^^^^^^^^^^^^
KeyError: 'pooled_output'

So I checked their codes https://github.com/NewBieAI-Lab/ComfyUI-Newbie-Nodes/blob/ed73daba8e17d4b7a57d9fd6c467a90ba12babc3/comfy_newbie_clip_loader.py#L555-L559, it turns out they directly return the clip_text_pooled args - it seems be not aligned with other clip processing in ComfyUI. Assume we should wait for proper native CLIP loader landed here.

Also, should we use clip_text_pooled = kwargs.get("pooled_output", None) as others? I can run with this edit, and while of course the clip doesn't work, the output image itself looks alright.

@MagicalAstrogy
Copy link

btw change to following content is also a solution

        if "clip_text_pooled" in kwargs:
            clip_text_pooled = kwargs["clip_text_pooled"]
        else:
            clip_text_pooled = kwargs["pooled_output"]  # Newbie

i'm not sure what the differences between simply set it to None....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants