Convert nearby package to kotlin #6570
Open
+2,301
−2,815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-raoul
left a comment
nicolas-raoul
left a comment
There was a problem hiding this comment.
I am not against reviewing this as a whole rather than as several pull requests, especially since this is all about Nearby.
Problem: Somehow, most pins are first red then become green. I will post a screencast from my phone.
Member
ab9f1af9-df28-4718-974c-28f4c0d93401.mp4 |
Member
|
On the opposite, on branch main, pins load to red or green and stay as such. |
Collaborator
Author
|
Thanks for the feedback - I'll dig into that! |
|
✅ Generated APK variants! |
Member
|
I am getting this crash when trying to upload via Nearby: 4605b9fa-e797-401a-ada8-a09633d38517.mp4In branch main, the same picture's metadata is loaded fine, and caption is correctly filled with the selected item's label. Would you mind checking? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue: #5928
I believe this converts the last remaining Java files to Kotlin in the project. Submitting as a Draft PR for now, as I know it's a little on the large size, and happy to break it into pieces for review and merging, or, convert to actual PR if you prefer.
Tested on Pixel 9 pro XL, all unit tests pass.