Fix #5788: Increase maximum zoom level on upload preview screen #6578
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5788
What changes did you make and why?
PhotoViewlibrary for zoom functionality. The default zoom limit of this library was too low (weak zoom), preventing contributors from inspecting fine details on their images.So, i resolved this by explicitly adding a call to:
(binding.backgroundImage as PhotoView).setMaximumScale(10.0f)This change is located in the
initializeFragment()method ofUploadMediaDetailFragment.kt. It overrides the restrictive default and enables up to 10.0x (1000% zoom), allowing for detailed quality checks before the image is finalized for upload.Tests performed
Tested
ProdDebugonRedmi Note 13 Pro 5gwith API level35.Screenshots