-
Notifications
You must be signed in to change notification settings - Fork 195
feat(api)!: add toolset prompts infrastructure #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
docs/PROMPTS.md
Outdated
| ```toml | ||
| disable_toolset_prompts = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nader-ziada will this be a global option, or a per-toolset option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global option currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I included this in #556
Disabling Toolset Prompts
Administrators can disable all toolset-defined prompts via configuration, using only config-defined prompts:
based on what Nader initially implemented in #510
IMO maybe we SHOULD NOT provide this option at all (prompts don't have any involuntary impact on the LLM behavior or consume context-window tokens)
OR if you consider this of value, provide a consistent implementation with what we have for tools (EnabledTools / DisabledTools).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the sake of simplicity, will remove the flag completely
Enable toolset implementers to define MCP prompts programmatically as part of their toolset definition. - Add GetPrompts() method to Toolset interface - Collect prompts from all enabled toolsets - Merge config and toolset prompts (config takes precedence) - Add disable_toolset_prompts configuration option - Update all existing toolsets to implement GetPrompts() Signed-off-by: Nader Ziada <[email protected]>
691a239 to
c8bb280
Compare
Signed-off-by: Nader Ziada <[email protected]>
Fixes: #556
Enable toolset implementers to define MCP prompts programmatically as part of their toolset definition.