Skip to content

Conversation

@redbeam
Copy link
Contributor

@redbeam redbeam commented Nov 19, 2025

Rebased #1123 for release 4.20.

This adds the necessary steps for installation of the 9pfs client to the hyperv image. The binary is installed from a COPR repository. This binary is needed to enable 9P file sharing.

Summary by CodeRabbit

  • New Features

    • Added 9P filesystem support for Windows guest provisioning, enabling improved file sharing capabilities.
  • Improvements

    • Enhanced package management during disk provisioning to handle both standard and pre-downloaded packages more comprehensively.

This adds the necessary steps for installation of the 9pfs client
to the hyperv image. The binary is installed from a COPR repository.
This binary is needed to enable 9P file sharing.
@redbeam redbeam self-assigned this Nov 19, 2025
@openshift-ci openshift-ci bot requested review from cfergeau and gbraad November 19, 2025 14:36
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Walkthrough

Modifies createdisk.sh to add Windows-specific provisioning logic that conditionally enables COPR repository mskvarla/9pfs, downloads the 9pfs binary package, and appends it to pre-downloaded packages when SNC_GENERATE_WINDOWS_BUNDLE is enabled.

Changes

Cohort / File(s) Summary
Windows 9pfs Provisioning
createdisk.sh
Added conditional block to fetch and enable COPR repo mskvarla/9pfs, download 9pfs binary to ~/packages in download-only mode, disable repo, and append 9pfs to PRE_DOWNLOADED_ADDITIONAL_PACKAGES. Updated post-point package handling to process both ADDITIONAL_PACKAGES and PRE_DOWNLOADED_ADDITIONAL_PACKAGES.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify conditional logic for SNC_GENERATE_WINDOWS_BUNDLE flag
  • Confirm COPR repo enable/disable sequence and error handling
  • Check package list concatenation syntax (leading space in append)
  • Validate placement relative to existing qemu-user-static-x86 handling

Poem

🐰 A Windows bundle hops into view,
With 9pfs magic, provisioning anew,
The COPR repo dances in and out,
While packages gather without a doubt,
Conditions aligned, the build shines true! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title '[release-4.20] 9p: add 9p fuse client' clearly summarizes the main change: adding 9p fuse client to the release-4.20 branch, which aligns with the PR objective of installing the 9pfs client binary.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add_9pfs_4.20

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@redbeam redbeam changed the title 9p: steps for 9pfs binary installation in hyperv image [release-4.20] 9p: add 9p fuse client Nov 19, 2025
@anjannath
Copy link
Member

/test e2e-snc

@praveenkumar
Copy link
Member

@anjannath I think e2e failure is #1186 one, bundle was created.

@anjannath
Copy link
Member

@anjannath I think e2e failure is #1186 one, bundle was created.

ahh yes, sorry, i didn't look at the logs clearly

@anjannath
Copy link
Member

/test e2e-snc

@anjannath
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 27, 2025

@redbeam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc e7cd2b0 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@redbeam
Copy link
Contributor Author

redbeam commented Nov 27, 2025

Were there any fixes for #1186? If yes, I can rebase

@anjannath
Copy link
Member

Were there any fixes for #1186? If yes, I can rebase

no, i didn't look at it yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants