feat: customizable ttl #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Fernández <[email protected]>
Signed-off-by: Jesús Fernández <[email protected]>
Signed-off-by: Jesús Fernández <[email protected]>
Signed-off-by: Jesús Fernández <[email protected]>
fernandezcuesta
requested review from
negz,
sergenyalcin and
turkenf
as code owners
chlunde
reviewed
Jun 3, 2025
.github/workflows/ci.yml
Outdated
| # Common versions | ||
| GO_VERSION: '1.23.8' | ||
| GOLANGCI_VERSION: 'v1.62.0' | ||
| GO_VERSION: '1.24.1' |
There was a problem hiding this comment.
go1.24.3 was a security release so if updating to 1.24, it should be 1.24.3 (or .4 in a couple of days)
Signed-off-by: Jesús Fernández <[email protected]>
Contributor
Author
|
Is there a chance to get this PR reviewed, or in other words, is there anything utterly bad with it/some reason not to approve it? I can invest time resolving the conflicts but want to know first if it makes sense as is. 🙇 |
bobh66
requested changes
Dec 3, 2025
Collaborator
bobh66
left a comment
bobh66
left a comment
There was a problem hiding this comment.
Hi @fernandezcuesta - sorry for the delay. It looks like there are merge conflicts that need to be resolved.
Also I think it would be better to limit this PR to just the TTL changes and leave the other changes to separate PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add the ability to set a custom TTL for the function response.
It allows 3 ways to set it up besides the default, from lower to higher precedence:
Fixes #424
I have: