-
Notifications
You must be signed in to change notification settings - Fork 45
feat: support application settings #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BoxBoxJason
wants to merge
15
commits into
crossplane-contrib:master
Choose a base branch
from
BoxBoxJason:feat/application-settings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: support application settings #244
BoxBoxJason
wants to merge
15
commits into
crossplane-contrib:master
from
BoxBoxJason:feat/application-settings
+18,141
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b716312 to
e76b029
Compare
add a generator function for easy conversion on updates Signed-off-by: BoxBoxJason <[email protected]>
b44815f to
ae5ec2b
Compare
add a generator function for easy conversion on updates Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
ae5ec2b to
fe5ed77
Compare
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
pass `make reviewable test` Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Signed-off-by: BoxBoxJason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The goal of this PR is to introduce a way to support application settings configuration for the gitlab instance using the provider. This is greatly inspired from the terraform gitlab provider application settings resource
Fixes #243
I have:
make reviewable testto ensure this PR is ready for review.What was added:
How has this code been tested
I have a self hosted gitlab instance in my homelab (I can share the link with reviewers if required)
I don't use docker (and I don't have it installed), instead I use podman on my Fedora 43 (Workstation) machine
I setup a kind cluster with the KIND_EXPERIMENTAL_PROVIDER=podman, using
kind create cluster --name gitlabI install the crossplane helm chart
helm repo add crossplane-stable https://charts.crossplane.io/stablehelm install crossplane --namespace crossplane-system --create-namespace crossplane-stable/crossplaneI build the go code
make go.buildand then run it./_output/bin/linux_amd64/provider --debugI create the secret with my PAT (admin permissions)
k create secret generic gitlab-credentials -n crossplane-system --from-literal=token=EXAMPLE_VALUEI apply the providerconfig manifest:
I apply the applicationSettings manifest (this is a reduced number of values to not jam the description):
I check that parameters are applied and no errors appears.
I update the CRD with new values and check again for errors / that they are applied
I update the gitlab settings manually and confirm that they are reconciled
I delete the resource and check that nothing new happens, the resource gets deleted properly