Skip to content

feat: update functionality for job.log with name argument #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 2, 2025
Merged

feat: update functionality for job.log with name argument #146

merged 11 commits into from
Oct 2, 2025

Conversation

@nfrasser
Copy link
Member

@nfrasser nfrasser commented Sep 19, 2025

Update an existing log by providing a name for it. Can use the ID of a previously-logged event as a name. Named events are reset when adding a checkpoint.

For example, show a live progress bar in the job log.

for pct in range(1, 10):
    # example log: "Progress: [#####-----] 50%"
    job.log(f"Progress: [{'#' * pct}{'-' * (10 - pct)}] {pct * 10}%", name="progress")
    sleep(1)

@nfrasser
feat(event): add/update event log with name
c83bfa7 
Can use the event's ID as its name, named events reset when a checkpoint is created
@nfrasser
test(event): tests for updating logs
504049b
@nfrasser
test(event): cleanup
f43f513
@vercel
Copy link

vercel bot commented Sep 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cryosparc-tools Ready Ready Preview Comment Oct 2, 2025 9:35pm

@nfrasser nfrasser self-assigned this Sep 19, 2025
@nfrasser nfrasser marked this pull request as ready for review September 19, 2025 16:20
Puratinamu
Puratinamu reviewed Sep 23, 2025
View reviewed changes
@nfrasser nfrasser requested a review from Puratinamu September 23, 2025 19:36
Puratinamu
Puratinamu reviewed Sep 24, 2025
View reviewed changes
@nfrasser nfrasser requested a review from Puratinamu September 24, 2025 14:42
@nfrasser
refactor(event): separate name and ID arguments
2343312 
No longer use ID as name to reduce ambiguity
@nfrasser nfrasser merged commit 9a771e7 into develop Oct 2, 2025
11 checks passed
@nfrasser nfrasser deleted the nfrasser/sw-523-event-log-update branch October 2, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Puratinamu Puratinamu Puratinamu approved these changes

@notLiria notLiria notLiria approved these changes

Assignees

@nfrasser nfrasser

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nfrasser @Puratinamu @notLiria