Skip to content

Prohibit char codes that would overflow the BASE_MAP #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2025
Merged

Prohibit char codes that would overflow the BASE_MAP #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cjs/index.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,12 @@ function base (ALPHABET) {
const b256 = new Uint8Array(size)
// Process the characters.
while (psz < source.length) {
// Find code of next character
const charCode = source.charCodeAt(psz)
// Base map can not be indexed using char code
if (charCode > 255) { return }
// Decode character
let carry = BASE_MAP[source.charCodeAt(psz)]
let carry = BASE_MAP[charCode]
// Invalid character
if (carry === 255) { return }
let i = 0
Expand Down
6 changes: 5 additions & 1 deletion src/esm/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,12 @@ function base (ALPHABET) {
const b256 = new Uint8Array(size)
// Process the characters.
while (psz < source.length) {
// Find code of next character
const charCode = source.charCodeAt(psz)
// Base map can not be indexed using char code
if (charCode > 255) { return }
// Decode character
let carry = BASE_MAP[source.charCodeAt(psz)]
let carry = BASE_MAP[charCode]
// Invalid character
if (carry === 255) { return }
let i = 0
Expand Down
6 changes: 6 additions & 0 deletions test/fixtures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,12 @@
"alphabet": "0123456789fabcdef",
"description": "poorly formed alphabet",
"exception": "^TypeError: f is ambiguous$"
},
{
"alphabet": "base58",
"description": "character whose code exceeds the highest index of base map (>=256)",
"exception": "^Error: Non-base58 character$",
"string": "\u1000"
}
]
}
8 changes: 7 additions & 1 deletion ts_src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,14 @@ function base (ALPHABET: string): base.BaseConverter {

// Process the characters.
while (psz < source.length) {
// Find code of next character
const charCode = source.charCodeAt(psz)

// Base map can not be indexed using char code
if (charCode > 255) return

// Decode character
let carry = BASE_MAP[source.charCodeAt(psz)]
let carry = BASE_MAP[charCode]

// Invalid character
if (carry === 255) return
Expand Down