Skip to content

Conversation

@catatsuy
Copy link
Collaborator

@catatsuy catatsuy commented Jan 13, 2025

This pull request adds support for building Nginx with the zlib-ng compression library, alongside the existing zlib support. It introduces new configuration options, updates the builder logic to handle zlib-ng, and adds a dedicated workflow to test building with zlib-ng. The changes ensure zlib-ng can be selected, downloaded, built, and tested similarly to other supported libraries.

Key changes include:

zlib-ng Support in Build System:

  • Added ComponentZlibNG to the builder, with corresponding constants for version and download URL, and updated methods to handle naming, download URLs, and source paths for zlib-ng (builder/const.go, builder/builder.go). [1] [2] [3] [4] [5] [6] [7]
  • Updated MakeBuilder and related logic to recognize zlib-ng as a separate component and handle its download prefix.

CLI and Build Option Enhancements:

  • Added new CLI flags and options for enabling zlib-ng (--zlib-ng) and specifying its version (--zlibngversion). Updated option descriptions and defaults accordingly (option.go). [1] [2]
  • Updated the main build logic to recognize and process the zlib-ng options, including parallel downloading and extraction, and inclusion as a dependency when selected (nginx-build.go). [1] [2] [3] [4] [5]

Testing and Workflow:

  • Added a new GitHub Actions workflow job to build and test Nginx with zlib-ng, including patch application and configuration (.github/workflows/go.yml, config/configure.zlibng.example). [1] [2]
  • Extended builder tests to cover zlib-ng, ensuring correct naming and builder setup (builder/builder_test.go). [1] [2]

@catatsuy catatsuy force-pushed the feature-add-zlib-ng-support branch 5 times, most recently from effb235 to dbb03db Compare April 20, 2025 07:39
@catatsuy
Copy link
Collaborator Author

refs: nginx/nginx#644

@catatsuy catatsuy force-pushed the feature-add-zlib-ng-support branch from dbb03db to a134bca Compare October 25, 2025 04:58
@catatsuy catatsuy force-pushed the feature-add-zlib-ng-support branch from a134bca to ed43da1 Compare November 29, 2025 05:39
@catatsuy catatsuy force-pushed the feature-add-zlib-ng-support branch from a5197cb to f922395 Compare November 29, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants