Add GP support #179
Merged
Add GP support #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTNobel
approved these changes
Nov 22, 2025
| torch = None # type: ignore[assignment] | ||
|
|
||
| if TYPE_CHECKING: | ||
| # Type alias for multi-framework tensor types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up MR to #178 to add GP support. After adding GP support, functions had gotten quite long, so I created a bunch of helper functions to organize the code.
I found an odd quirk where CVXPY requires initial values for parameters to get the DPP mapping for DGP problems. I was able to remove this limitation with hacky subclassing of CVXPY, but it would be better to fix the issue on the CVXPY side.