Skip to content

Add webgl edge guard in texture getter #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

Add webgl edge guard in texture getter #3403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4abef71
Add webgl edge guard in texture getter
maxkfranz Jul 31, 2025
82ae6e3
Apply patch only to invalid edges
maxkfranz Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/extensions/renderer/canvas/webgl/drawing-elements-webgl.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,13 @@ export class ElementDrawingWebGL {
return;
}

// Edges with invalid points could be passed here (labels), causing errors
// Ref: Random "Script Error" thrown when generating nodes and edges in newest webgl version #3365
// https://github.com/cytoscape/cytoscape.js/issues/3365
if(ele.isEdge() && !this._isValidEdge(ele)) {
return;
}

if(this.renderTarget.picking && opts.getTexPickingMode) {
const mode = opts.getTexPickingMode(ele);
if(mode === TEX_PICKING_MODE.IGNORE) {
Expand Down Expand Up @@ -989,11 +996,21 @@ export class ElementDrawingWebGL {
}
}

_isValidEdge(edge) {
const rs = edge._private.rscratch;

if( rs.badLine || rs.allpts == null || isNaN(rs.allpts[0]) ){ // isNaN in case edge is impossible and browser bugs (e.g. safari)
return false;
}

return true;
}

_getEdgePoints(edge) {
const rs = edge._private.rscratch;

// if bezier ctrl pts can not be calculated, then die
if( rs.badLine || rs.allpts == null || isNaN(rs.allpts[0]) ){ // isNaN in case edge is impossible and browser bugs (e.g. safari)
if(!this._isValidEdge(edge)){ // isNaN in case edge is impossible and browser bugs (e.g. safari)
return;
}
const controlPoints = rs.allpts;
Expand Down
Loading