Skip to content

gitlab: Fix Gitlab parsing error by changing ids to Long #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

gitlab: Fix Gitlab parsing error by changing ids to Long #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/gitlab/GitLab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ data class GitLabMergeRequest(
val firstDeployedToProductionAt: Instant? = null,
@SerialName("force_remove_source_branch")
val forceRemoveSourceBranch: Boolean? = null,
val id: Int,
val iid: Int,
val id: Long,
val iid: Long,
@SerialName("latest_build_finished_at")

val latestBuildFinishedAt: Instant? = null,
Expand Down Expand Up @@ -147,10 +147,10 @@ data class GitLabMilestone(
val description: String,
@SerialName("due_date")
val dueDate: Instant,
val id: Int,
val iid: Int,
val id: Long,
val iid: Long,
@SerialName("project_id")
val projectID: Int,
val projectID: Long,
@SerialName("start_date")
val startDate: Instant,
val state: GitLabMilestoneState,
Expand All @@ -172,7 +172,7 @@ enum class GitLabMilestoneState {

@Serializable
data class GitLabPipeline(
val id: Int,
val id: Long,
val ref: String,
val sha: String,
val status: GitLabPipelineStatus,
Expand Down Expand Up @@ -205,7 +205,7 @@ enum class GitLabPipelineStatus {
data class GitLabUser(
@SerialName("avatar_url")
val avatarUrl: String? = null,
val id: Int,
val id: Long,
val name: String,
val state: GitLabUserState,
val username: String,
Expand Down
16 changes: 8 additions & 8 deletions ...-kotlin-library/src/test/kotlin/systems/danger/kotlin/models/gitlab/GitLabParsingTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ class GitLabParsingTests {
assertEquals(false, allowMaintainerToPush)
assertEquals(1, approvalsBeforeMerge)
val orta = GitLabUser(
"https://secure.gravatar.com/avatar/f116cb3be23153ec08b94e8bd4dbcfeb?s=80&d=identicon", 377669, "Orta",
"https://secure.gravatar.com/avatar/f116cb3be23153ec08b94e8bd4dbcfeb?s=80&d=identicon", 377669L, "Orta",
GitLabUserState.ACTIVE, "orta", "https://gitlab.com/orta"
)
assertEquals(orta, assignee)
val fmeloni = GitLabUser(
"https://secure.gravatar.com/avatar/3d90e967de2beab6d44cfadbb4976b87?s=80&d=identicon",
3331525,
3331525L,
"Franco Meloni",
GitLabUserState.ACTIVE,
"f-meloni",
Expand All @@ -48,8 +48,8 @@ class GitLabParsingTests {
assertEquals(0, downvotes)
assertEquals(Instant.fromEpochMilliseconds(1554942622492), firstDeployedToProductionAt)
assertEquals(true, forceRemoveSourceBranch)
assertEquals(27469633, id)
assertEquals(182, iid)
assertEquals(27469633L, id)
assertEquals(182L, iid)
assertEquals(Instant.fromEpochMilliseconds(1554942802492), latestBuildFinishedAt)
assertEquals(Instant.fromEpochMilliseconds(1619786100103), latestBuildStartedAt)
assertEquals(listOf<String>(), labels)
Expand All @@ -61,9 +61,9 @@ class GitLabParsingTests {
Instant.fromEpochMilliseconds(1554933465346),
"Test Description",
Instant.fromEpochMilliseconds(1560124800000),
1,
2,
1000,
1L,
2L,
1000L,
Instant.fromEpochMilliseconds(1554933465346),
GitLabMilestoneState.CLOSED,
"Test Milestone",
Expand All @@ -72,7 +72,7 @@ class GitLabParsingTests {
)
assertEquals(expectedMilestone, milestone)
val expectedPipeline = GitLabPipeline(
50,
50L,
"ef28580bb2a00d985bffe4a4ce3fe09fdb12283f",
"621bc3348549e51c5bd6ea9f094913e9e4667c7b",
GitLabPipelineStatus.SUCCESS,
Expand Down
Loading