Propagates UseJsonSerialization setting #1648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeBobo5
force-pushed
the
fix/missing-propery-propagation
branch
from
cea3d32 to
6c55ba9
Compare
Ensures the UseJsonSerialization option is correctly passed through when configuring actor runtime settings, maintaining consistent serialization behavior. Signed-off-by: Laurent BOHEAS <[email protected]> Signed-off-by: ZeBobo5 <[email protected]>
ZeBobo5
force-pushed
the
fix/missing-propery-propagation
branch
from
6c55ba9 to
ea3a795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1647
Expected Behavior
The
UseJsonSerializationoption should be correctly passed to theActorRuntimeOptionsconfiguration so that JSON serialization is properly used when configured.Actual Behavior
The line
is missing in the code block inside
[ActorsServiceCollectionExtensions.cs](https://github.com/dapr/dotnet-sdk/blob/274eb529b11d36d490070530afff49d774fe0bb4/src/Dapr.Actors.AspNetCore/ActorsServiceCollectionExtensions.cs#L62).As a result, JSON deserialization may not work as expected.
Steps to Reproduce the Problem
UseJsonSerialization = true.Release Note
RELEASE NOTE: FIX Missing propagation of
UseJsonSerializationoption inActorsServiceCollectionExtensions.