#3182. Update augmenting_constructors_A11-18* tests #3417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
Nov 27, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
Looks good. Commented on a couple of apparently unintended errors and one terminology issue.
LanguageFeatures/Augmentations/augmenting_constructors_A17_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentations/augmenting_constructors_A18_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentations/augmenting_constructors_A18_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentations/augmenting_constructors_A18_t01.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
Nov 27, 2025
Contributor
Author
sgrekhov
left a comment
sgrekhov
left a comment
There was a problem hiding this comment.
Thank you. Updated. PTAL.
LanguageFeatures/Augmentations/augmenting_constructors_A17_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentations/augmenting_constructors_A18_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentations/augmenting_constructors_A18_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentations/augmenting_constructors_A18_t01.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 28, 2025
2025-11-27 [email protected] dart-lang/co19#3182. Update augmenting_constructors_A11-18* tests (dart-lang/co19#3417) 2025-11-27 [email protected] dart-lang/co19#3182. Update `augmenting_declarations_*` tests (dart-lang/co19#3420) 2025-11-27 [email protected] dart-lang/co19#3182. Add more tests for constructors augmentation (dart-lang/co19#3419) 2025-11-26 [email protected] dart-lang/co19#3182. Rename some test for constructors (dart-lang/co19#3416) 2025-11-25 [email protected] dart-lang/co19#3182. Update augmenting_constructors_A09* tests (dart-lang/co19#3415) 2025-11-25 [email protected] dart-lang/co19#3182. Update augmenting_constructors_A02-04* tests (dart-lang/co19#3413) 2025-11-25 [email protected] dart-lang/co19#3182. Update augmenting_constructors_A05-08* tests (dart-lang/co19#3414) 2025-11-24 [email protected] dart-lang/co19#3182. Rename `Augmentation-libraries` to `Augmentations` (dart-lang/co19#3412) [email protected], [email protected] Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465020 Commit-Queue: Alexander Thomas <[email protected]> Commit-Queue: Erik Ernst <[email protected]> Auto-Submit: Sergey Grekhov <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also it's just a first step. The next step is renaming.