Skip to content

refactor: Unify get_current_checkpoint_from_pipeline helper #15487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
libvarun wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: Unify get_current_checkpoint_from_pipeline helper #15487

libvarun wants to merge 2 commits into from
+31 −38

Conversation

@libvarun
Copy link
Contributor

@libvarun libvarun commented Dec 5, 2025

Summary of changes:

  1. Refactor: Moved get_current_checkpoint_from_pipeline to metadata-ingestion/src/datahub/testing/state_helpers.py to allow sharing between test suites.
  2. Cleanup: Removed duplicate implementation from smoke-test/tests/test_stateful_ingestion.py and updated metadata-ingestion tests to use the shared helper.
  3. Verification: Ran smoke-test and relevant unit tests locally, and they passed.

No Deps changed.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata smoke_test Contains changes related to smoke tests community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 5, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 5, 2025
@deepgarg760
Copy link
Collaborator

deepgarg760 commented Dec 5, 2025

@libvarun , linting please

@deepgarg760
Copy link
Collaborator

deepgarg760 commented Dec 5, 2025

LGTM!!

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata pending-submitter-response Issue/request has been reviewed but requires a response from the submitter smoke_test Contains changes related to smoke tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@libvarun @deepgarg760 @varunpatil578