Skip to content

Conversation

@daha
Copy link
Contributor

@daha daha commented Dec 5, 2025

This MR add a option like for the powerbi source to use the user email for the corpuser URN or just the part before @. Default to the part before @ as that is the behavior before this change.

Also so not add the unique dashboard id as a dashboard owner. I really do not understand why that was added in the first place. If someone really need it, it can be added by a transformer as the dashboard id is part of the dashboard URN.

yaml
*Example Grafana recipe configuration*

source:
  type: grafana
  config:
    url: "https://your-grafana.com/"
    
    # Example 1: Default behavior (strip emails to usernames)
    # This creates: urn:li:corpuser:john
    remove_email_suffix: true  # or omit (this is default)
    
    # Example 2: Keep full email as corporate user identifier
    # This creates: urn:li:corpuser:[email protected]
    # Use this if your company's SSO/LDAP uses full emails as user IDs
    remove_email_suffix: false
  • The PR conforms to DataHub's Contributing Guideline (particularly PR Title Format)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Dec 5, 2025
@daha daha changed the title feat(ingestion/grafana) add option to pass grafana as is as dashboard owner feat(ingestion/grafana) add option to pass grafana user email as is as dashboard owner Dec 5, 2025
@daha daha changed the title feat(ingestion/grafana) add option to pass grafana user email as is as dashboard owner feat(ingestion/grafana) add option to pass grafana user email as dashboard owner Dec 5, 2025
@daha daha force-pushed the source-grafana-dashboard-owner-improvement branch from 01071c7 to 26e9217 Compare December 5, 2025 13:17
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Dec 5, 2025
@daha daha force-pushed the source-grafana-dashboard-owner-improvement branch from 26e9217 to 5964397 Compare December 5, 2025 18:14
@deepgarg760
Copy link
Collaborator

@daha , Good work!!
Please add documentation regarding change in the owner type

@datahub-cyborg datahub-cyborg bot added merge-pending-ci A PR that has passed review and should be merged once CI is green. and removed needs-review Label for PRs that need review from a maintainer. labels Dec 8, 2025
@daha daha force-pushed the source-grafana-dashboard-owner-improvement branch from 5964397 to ba28982 Compare December 8, 2025 18:20
@daha
Copy link
Contributor Author

daha commented Dec 8, 2025

@daha , Good work!! Please add documentation regarding change in the owner type

Where should that information be added, @deepgarg760?

@daha
Copy link
Contributor Author

daha commented Dec 8, 2025

I have renamed the configuration option, used the one used in powerbi source instead, which I think has a better name. I have updated the docs for the source a bit. @deepgarg760

@codecov
Copy link

codecov bot commented Dec 8, 2025

Bundle Report

Changes will decrease total bundle size by 23.61kB (-0.08%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.74MB -23.61kB (-0.08%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js -23.61kB 19.11MB -0.12%

@daha daha force-pushed the source-grafana-dashboard-owner-improvement branch from e6e3c0e to 6a9ae87 Compare December 8, 2025 20:10
…board owner

Also remove the unique id of the dashboard as a owner.
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@deepgarg760 deepgarg760 merged commit a0dded2 into datahub-project:master Dec 10, 2025
92 of 94 checks passed
@daha daha deleted the source-grafana-dashboard-owner-improvement branch December 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PR or Issue raised by member(s) of DataHub Community depot ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants