-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ingestion/grafana) add option to pass grafana user email as dashboard owner #15489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion/grafana) add option to pass grafana user email as dashboard owner #15489
Conversation
01071c7 to
26e9217
Compare
26e9217 to
5964397
Compare
|
@daha , Good work!! |
5964397 to
ba28982
Compare
Where should that information be added, @deepgarg760? |
ba28982 to
de626b5
Compare
de626b5 to
e6e3c0e
Compare
|
I have renamed the configuration option, used the one used in powerbi source instead, which I think has a better name. I have updated the docs for the source a bit. @deepgarg760 |
Bundle ReportChanges will decrease total bundle size by 23.61kB (-0.08%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
|
e6e3c0e to
6a9ae87
Compare
…board owner Also remove the unique id of the dashboard as a owner.
6a9ae87 to
b167dd8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This MR add a option like for the powerbi source to use the user email for the corpuser URN or just the part before @. Default to the part before @ as that is the behavior before this change.
Also so not add the unique dashboard id as a dashboard owner. I really do not understand why that was added in the first place. If someone really need it, it can be added by a transformer as the dashboard id is part of the dashboard URN.