-
Notifications
You must be signed in to change notification settings - Fork 3.3k
refactor(test): Use Kafka consumer offsets API for lag #15502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
✅ Meticulous spotted 0 visual differences across 992 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit d14644d. This comment will update as new commits are pushed. |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
david-leifker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 ms interval and the underlying method is skipCache by default. This is not ideal. The get_kafka_consumer_offsets() method should not be disabling cache by default. The main loop is too tight, increased busy work, and potentially misses something if the lag goes to zero momentarily.
No description provided.