feat(ingestion): Restores "Extending file sink to support writing to S3 (#14160) (#14248)" #15504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jjoyce0510
approved these changes
Dec 9, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
esteban
force-pushed
the
restore_pr14160
branch
from
abd5581 to
c330017
Compare
esteban
force-pushed
the
restore_pr14160
branch
from
c330017 to
5c675af
Compare
Collaborator
Author
|
Are we good with this @jjoyce0510? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fe3ffc1 in order to restore #14160