-
Notifications
You must be signed in to change notification settings - Fork 91
Chore/dev env fixes #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pre/v2.0
Are you sure you want to change the base?
Chore/dev env fixes #1279
Conversation
| // Uncomment to connect as an existing user other than the container default. More info: https://aka.ms/dev-containers-non-root. | ||
| // "remoteUser": "devcontainer" | ||
| } | ||
| "image": "mcr.microsoft.com/devcontainers/typescript-node:0-18", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just need pixi and docker now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodejs is in here for LLM tooling, we can remove if that's not needed
| #! /usr/bin/bash | ||
| # This script registers dot plugins so that we can use graphviz | ||
| # to write png images | ||
| dot -c No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the dot tool used by graphviz uses a post-installation step to register different file format backends. this script performs that step. without this, the graphviz-related tests will fail in a fresh environment.
| "setuptools", | ||
| ] | ||
| requires-python = ">=3.9,<4.0" | ||
| requires-python = ">=3.9,<3.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linux tests fail on python 3.14 due to attempts to pickle things that should not be pickled (locks). Fixing this architecturally requires quite a bit more work so we avoid python 3.14 for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.9 has reached its end of life.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 then lets move to 3.11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a lower bound
| hooks: | ||
| - id: black | ||
| args: ["--check", "-v", "src", "tests", "--diff"] # --required-version is conflicting with pre-commit | ||
| args: ["-v", "src", "tests", "--diff"] # --required-version is conflicting with pre-commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes pre-commit much more useful by applying the formatting changes
Applies more fixes to the developer environment. I will add explanatory comments to new / altered files.