Skip to content

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 10, 2025

Applies more fixes to the developer environment. I will add explanatory comments to new / altered files.

@github-actions github-actions bot added bug Indicates an unexpected problem or unintended behavior enhancement Indicates new improvements labels Nov 10, 2025
// Uncomment to connect as an existing user other than the container default. More info: https://aka.ms/dev-containers-non-root.
// "remoteUser": "devcontainer"
}
"image": "mcr.microsoft.com/devcontainers/typescript-node:0-18",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need pixi and docker now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs is in here for LLM tooling, we can remove if that's not needed

Comment on lines +1 to +4
#! /usr/bin/bash
# This script registers dot plugins so that we can use graphviz
# to write png images
dot -c No newline at end of file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dot tool used by graphviz uses a post-installation step to register different file format backends. this script performs that step. without this, the graphviz-related tests will fail in a fresh environment.

"setuptools",
]
requires-python = ">=3.9,<4.0"
requires-python = ">=3.9,<3.14"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linux tests fail on python 3.14 due to attempts to pickle things that should not be pickled (locks). Fixing this architecturally requires quite a bit more work so we avoid python 3.14 for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 has reached its end of life.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 then lets move to 3.11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a lower bound

hooks:
- id: black
args: ["--check", "-v", "src", "tests", "--diff"] # --required-version is conflicting with pre-commit
args: ["-v", "src", "tests", "--diff"] # --required-version is conflicting with pre-commit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes pre-commit much more useful by applying the formatting changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Indicates an unexpected problem or unintended behavior enhancement Indicates new improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants