Skip to content

Generalized fetching of uid and add support for DBUS_UID env var #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generalized fetching of uid and add support for DBUS_UID env var #76

wants to merge 1 commit into from

Conversation

@martenjacobs
Copy link
Contributor

@martenjacobs martenjacobs commented May 12, 2021

Solves #75

@acrisci
Copy link
Member

acrisci commented May 20, 2021

I don't like the idea of an env var. Does process.getuid() not give you the right value?

@martenjacobs
Copy link
Contributor Author

martenjacobs commented May 20, 2021

I don't like the idea of an env var. Does process.getuid() not give you the right value?

No it doesn’t, because the process is running under macOS and is connecting to DBus on another machine through TCP.
A nicer solution could be to add the uid to the params of the bus constructor. I just choose the env var approach because it was simpler to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martenjacobs @acrisci