Use synctest instead of fakeclock in tests #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
1 similar comment
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
AnomalRoil
force-pushed
the
dkg/synctest
branch
from
951b0a4 to
279ca8d
Compare
Contributor
Author
|
This is weird, I would expect it to pickup my new github workflow file that specifies go 1.25 but it seems it keeps using the old values weirdly. |
Contributor
|
Yes, it's designed to use the repo's GitHub actions. |
Contributor
|
go 1.25 and golangci-lint setup are already part of the int32-reviewed branch that should be merged to master soon-ish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a newly added feature of Go 1.25:
synctestallows to use thetimepackage like one would in real life, and have a specialsynctestbubble in which tests are run where synchronization of goroutine can be ensured by callingsynctest.Wait()after atime.Sleep()has been called, e.g.It also will warn about deadlock caused by
time.Sleepand such in go routines.