Fix: Prevent infinite “A5A5A5...” repetition loop in generate() (Issue #1008) #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion (Issue deepseek-ai#1008) Added a simple repetition detection inside the generate() loop to stop the model from endlessly producing patterns like “A5A5A5...”. - Imported `re` for regex pattern matching. - Stops generation if “A5” repeats 10+ times or the same token appears 10 times. - Prints a warning and exits safely instead of looping infinitely. Fixes: deepseek-ai#1008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the infinite generation loop issue that occurred when the model
encountered repeating checksum-like patterns such as “A5A5A5A5...”.
Changes Made
import refor regex-based pattern detection.generate()function:(A5){10,}regex.Result
Fixes: #1008