feat: migrate protocol validation to table_configuration #1411
+196
−310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
DrakeLin
force-pushed
the
drake-lin_data/migrate-protocol-validation
branch
3 times, most recently
from
a6b6c01 to
e76c455
Compare
DrakeLin
changed the title
DrakeLin
force-pushed
the
drake-lin_data/migrate-protocol-validation
branch
from
e76c455 to
7d1fa83
Compare
DrakeLin
commented
Nov 15, 2025
|
|
||
| /// Returns `Ok` if the kernel supports reading from this table. This checks that the | ||
| /// protocol's reader features are all supported. | ||
| fn ensure_read_supported(&self) -> DeltaResult<()> { |
Collaborator
Author
There was a problem hiding this comment.
to reviewers: does this make sense to take out of protocol? We can keep this and helper functions as protocol implementations if we think it makes more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR migrates protocol support/enablement validation logic from Protocol to TableConfiguration.
How was this change tested?
Existing and new tests