added ability to set timeouts #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyNovikov89
force-pushed
the
master
branch
from
3ff1ce7 to
7c88d37
Compare
korvalanni
reviewed
Dec 22, 2024
| private int maxConnectionsPerRoute; | ||
| private int connectionRequestTimeout; | ||
| private int connectTimeout; | ||
| private int socketTimeout; |
Contributor
There was a problem hiding this comment.
можно сделать поля final, а новые опциональными для обратной совместимости
korvalanni
reviewed
Dec 22, 2024
| private int socketTimeout; | ||
|
|
||
| public ConnectionSettings(int maxTotalConnections, int maxConnectionsPerRoute) { | ||
| public ConnectionSettings(int maxTotalConnections, int maxConnectionsPerRoute, |
Contributor
There was a problem hiding this comment.
Ломается обратная совместимость, лучше добавить конструктор рядом
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.