-
Notifications
You must be signed in to change notification settings - Fork 930
Lua improvements #8071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua improvements #8071
Conversation
e2eaf3a to
3cce0d2
Compare
79802d1 to
dac6d36
Compare
Pull request was converted to draft
1ac2a34 to
36cafb3
Compare
Also renames lua/lua.hpp to lua/lua_global.hpp. The previous name broke version auto-detection in sol2, which involves calling `__has_include(<lua/lua.hpp>)`.
1. Follows advice from https://sol2.readthedocs.io/en/latest/functions.html to use `set_function` when binding functions. 2. Adds autocomplete support for userdata methods. 3. Simplifies property bindings and improves string handling.
Filter out more cases where autocomplete just gets in the way.
|
@glebm patch application currently fails on Windows MSVC |
|
@tsunamistate make sure you have patch.exe installed in your system PATH so that cmake can find it. |
|
@AJenbo my |
|
Oh, sorry about that. Can you try in the following order:
If none of that works, I suppose we could fork a diasurgical/sol2 repo and have a branch with the patches that we want. |
Multiple Lua improvements:
Follows advice from https://sol2.readthedocs.io/en/latest/functions.html to use
set_functionwhen binding functions.Adds autocomplete support for userdata methods, including handling
.vs::Updates Lua and sol2 (with some patches for yet-to-be-merged PRs).