Moved the BtchBookg node to the correct position and introduced the missing Issr node #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing Issr node.
|
Just for reference: This is fixed in the new repository php-sepa-xml/php-sepa-xml@d415426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the pain format .xsd's, BtchBookg should always reside in the PaymentInstructionInformation node.
In the past there was a 001.001.02 format that required the BtchBookg to reside in the Header, this is no longer the case in the newer formats.
This library claims support for 'pain.001.002.03', 'pain.001.001.03', 'pain.008.002.02', 'pain.008.001.02' which all require the BtchBookg to be in the PaymentInstructionInformation.
The other implemented child of the BaseDomBuilder, CustomerDirectDebitTransferDomBuilder never used the BatchBooking so it should continue to work.
Finally, the supported formats describe BtchBookg as 'minOccurs="0"', so omission of the field should not break functionality.
http://docs.oracle.com/cd/E16582_01/doc.91/e15104/fields_sepa_pay_file_appx.htm
https://www.ing.be/SiteCollectionDocuments/XMLGuide_ECT_EN.pdf