-
Notifications
You must be signed in to change notification settings - Fork 349
New Frontend + backend pagination #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
hey, thank you for your valuable contribution! before I can review this I would need a cleaner PR unfortunately. you seem to have checked out a version of roadtools at some point, and now made a commit with all the changes. however, this reverts all the changes that have been made to the original project in the meanwhile (see for example the many changes in roadlib/roadtx that have nothing to do with the frontend). Could you submit a clean PR with only the new UI files? |
|
Hi @dirkjanm ! Sorry for the dirty PR. I cleaned up the PR. I had to make some changes to the backend in server, mainly to handle the Conditional Access Policies and backend pagination. I should be all fine now, do not hesitate to contact me if other changes are required. |
|
Seems to be a beautiful update! Keen on seeing this on prod' |
As discussed earlier, I finally managed to finish this PR
This PR includes a new UI built using Vite + Vue, a Cruip template based on Tailwind CSS and the PrimeVue framework
Among the new features:
No changes to the database structure have been made, so it's fully compatible with the previous version of Roadrecon.
The UI is based on the previous version, there should be no loss of information.
I tried to minimize changes to the backend, the major changes are related to the Policies handling.
Regarding the license issue. The Cruip template is licensed under GPL. I'm not a license expert, but if I understood well, we need to change the license to GPL if the project includes GPL code... Or I might need to use another template. Don't have any opinion on this point to be honest.
Thanks again for this amazing tool !