Skip to content

Increase multi option performance by not doing a query if its already prefetched #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Increase multi option performance by not doing a query if its already prefetched #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oscar_odin/mappings/catalogue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def _attribute_value_to_native_type(item):
return item.value.option

elif obj_type == item.attribute.MULTI_OPTION:
return item.value.values_list("option", flat=True)
return [value.option for value in item.value]

elif obj_type == item.attribute.FILE:
return item.value.url
Expand Down