Add RegexLeakHandler to allow callers to supply a custom leak handler
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to execute when a regex leak is detected.
zachmu
approved these changes
Mar 19, 2025
Member
zachmu
left a comment
zachmu
left a comment
There was a problem hiding this comment.
LGTM but @Hydrocharged should take a peek when he has a chance (after merge).
| } else if ShouldPanic { | ||
| panic("Finalizer found a Regex that was never closed") | ||
| } | ||
| _ = pr.Close() |
Member
There was a problem hiding this comment.
I don't know of any reason this wouldn't be safe to do at finalization time, but Daylon should give his opinion here too.
Collaborator
There was a problem hiding this comment.
Looking through the code a bit, I can't find nor think of a good reason as to why this shouldn't be fine, so I approve.
Collaborator
Hydrocharged
left a comment
Hydrocharged
left a comment
There was a problem hiding this comment.
The change looks fine to me, no additional comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers can override
regex.RegexLeakHandlerto supply their own custom function to be invoked when finalizing aregex.Regexinstance that hasn't had itsClose()method called.For this initial version, the callback function doesn't take any arguments, but we could supply the
Regexinstance as an argument and add aString()method to theRegexinterface to allow the caller to see more information on whichRegexinstance was leaked.