Skip to content

Conversation

@marcominerva
Copy link
Contributor

Description

Refactor RequestDelegateFactory to handle parameter binding failures more flexibly:

  • Execute filter pipelines on failure if filters are present and return type is ValueTask<object?>, allowing filters to observe/modify the 400 response.
  • Short-circuit with a 400 response if no filters are present.
  • Simplify logic using Expression.Condition and Expression.Block.

Add new test cases in RouteHandlerEndpointRouteBuilderExtensionsTest.cs:

  • Validate behavior with/without filters and custom responses.
  • Ensure handlers are not executed on binding failure.

Fixes #64341

Refactor `RequestDelegateFactory` to handle parameter binding
failures more flexibly:
- Execute filter pipelines on failure if filters are present
  and return type is `ValueTask<object?>`, allowing filters
  to observe/modify the 400 response.
- Short-circuit with a 400 response if no filters are present.
- Simplify logic using `Expression.Condition` and
  `Expression.Block`.

Add new test cases in `RouteHandlerEndpointRouteBuilderExtensionsTest.cs`:
- Validate behavior with/without filters and custom responses.
- Ensure handlers are not executed on binding failure.
Copilot AI review requested due to automatic review settings November 26, 2025 11:16
@github-actions github-actions bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 26, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 26, 2025
Copilot finished reviewing on behalf of marcominerva November 26, 2025 11:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors parameter binding failure handling in RequestDelegateFactory to provide more flexible filter integration. The key change allows endpoint filters to observe and potentially customize 400 Bad Request responses when parameter binding fails, rather than always short-circuiting before filters run.

Key Changes:

  • Unified the parameter binding failure logic using Expression.Condition instead of separate code paths for filtered vs non-filtered scenarios
  • When filters are present and return type is ValueTask<object?>, the filter pipeline executes on binding failure, allowing filters to customize the 400 response
  • Added comprehensive test coverage for binding failure scenarios with and without filters

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Http/Http.Extensions/src/RequestDelegateFactory.cs Refactored CreateParamCheckingResponseWritingMethodCall to conditionally run filter pipelines on parameter binding failures, simplifying the code with a unified Expression.Condition approach
src/Http/Routing/test/UnitTests/Builder/RouteHandlerEndpointRouteBuilderExtensionsTest.cs Added 4 test cases validating parameter binding failure behavior: with/without filters, with custom filter responses, and with validation filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member feature-rdg pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using AddValidation causes non-validated Minimal API endpoints to continue after parsing errors

2 participants