Skip to content

Fix packaging issues in SOS containing packages #5611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 24, 2025
Merged

Fix packaging issues in SOS containing packages #5611

merged 5 commits into from
Oct 24, 2025

Conversation

@hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Oct 24, 2025 •
edited
Loading

No description provided.

@hoyosjs hoyosjs marked this pull request as ready for review October 24, 2025 10:58
@hoyosjs hoyosjs requested a review from a team as a code owner October 24, 2025 10:58
@hoyosjs hoyosjs enabled auto-merge (squash) October 24, 2025 10:58
@hoyosjs hoyosjs disabled auto-merge October 24, 2025 10:58
@hoyosjs hoyosjs marked this pull request as draft October 24, 2025 11:09
@hoyosjs hoyosjs force-pushed the juhoyosa/fix-packaging branch from 65deb46 to 173069c Compare October 24, 2025 12:29
@hoyosjs hoyosjs marked this pull request as ready for review October 24, 2025 12:35
@hoyosjs hoyosjs marked this pull request as draft October 24, 2025 12:35
@hoyosjs hoyosjs force-pushed the juhoyosa/fix-packaging branch from 173069c to 3f918df Compare October 24, 2025 12:38
@hoyosjs hoyosjs marked this pull request as ready for review October 24, 2025 13:08
@hoyosjs
Copy link
Member Author

hoyosjs commented Oct 24, 2025

Official bits to test: https://dev.azure.com/dnceng/internal/_build/results?buildId=2823705&view=results

steveisok
steveisok previously approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job working this out!

@hoyosjs hoyosjs force-pushed the juhoyosa/fix-packaging branch 2 times, most recently from b728514 to a29e178 Compare October 24, 2025 20:05
steveisok
steveisok previously approved these changes Oct 24, 2025
View reviewed changes
@hoyosjs hoyosjs force-pushed the juhoyosa/fix-packaging branch from a29e178 to 320bfa7 Compare October 24, 2025 20:59
@steveisok steveisok self-requested a review October 24, 2025 21:55
@hoyosjs hoyosjs merged commit 73f1fdc into dotnet:main Oct 24, 2025
19 checks passed
@hoyosjs hoyosjs deleted the juhoyosa/fix-packaging branch October 24, 2025 23:13
@hoyosjs hoyosjs mentioned this pull request Oct 24, 2025
Merged
hoyosjs added a commit to hoyosjs/diagnostics that referenced this pull request Oct 24, 2025
@hoyosjs
Fix packaging issues in SOS containing packages (dotnet#5611)
0c2eebc
@hoyosjs hoyosjs mentioned this pull request Oct 24, 2025
Closed
hoyosjs added a commit that referenced this pull request Oct 25, 2025
@hoyosjs
Backport select changes and fixes (#5615)
9e46ef4 
- **Add uncompressed manifest generation to SOS build (#5603)**
- **Allow to run diagnostics pipeline in build-only mode (#5613)**
- **Fix packaging issues in SOS containing packages (#5611)**
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveisok steveisok steveisok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoyosjs @steveisok