-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix updating globaljsonworkloadsets.json
#50372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
angyanmark
wants to merge
13
commits into
dotnet:main
Choose a base branch
from
angyanmark:fix-globaljsonworkloadsets-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix updating globaljsonworkloadsets.json
#50372
angyanmark
wants to merge
13
commits into
dotnet:main
from
angyanmark:fix-globaljsonworkloadsets-json
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globaljsonworkloadsets.json
This was referenced Nov 6, 2025
This was referenced Nov 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic sets the file stream position to 0, and overwrites the content of the
globaljsonworkloadsets.jsonfile.If the new content is shorter, then some characters remain from the old content, thus making the JSON malformed.
Example
workloadVersioninglobal.jsonto9.0.303.1.dotnet workload restoremakes the content ofglobaljsonworkloadsets.jsonthe following:{ "<path-to-global-json>": "9.0.303.1" }workloadVersioninglobal.jsonto9.0.304.dotnet workload restoreoutputs this warning:and makes the content of
globaljsonworkloadsets.jsonthe following:{ "<path-to-global-json>": "9.0.304" } }The new version number is 2 characters shorter, so 2 characters from the old content of the file remains.
This is not a valid JSON and causes any subsequent
dotnet workload restorecommand to fail with error:Fix
This fix sets the stream length to 0, truncating the stream, so there will be no remainder of the old content.
Also, as per
SetLengthdocumentation:if the current position is greater than the new length, the current position is moved to the last byte of the stream, soSeekis unnecessary.