chore: remove catalina support #800
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <[email protected]>
… shane/catalina-support Signed-off-by: Emanuele Feliziani <[email protected]> # Conflicts: # dist/autofill-debug.js # dist/autofill.js
… shane/catalina-support Signed-off-by: Emanuele Feliziani <[email protected]> # Conflicts: # dist/autofill-debug.js # dist/autofill.js
Member
|
@shakyShane Yo! I saw this in the list and merged the latest from main and removed one failing test. The test was a Catalina-specific test and since we've removed all that it was not needed (and of course it was failing, the feature is no longer there). Were you planning anything else here? |
Contributor
|
Hey @shakyShane are you planning to continue working on this PR? |
Collaborator
|
Taking this over from Shane (discussed on MM). |
Bundle size change (main vs. current)autofill.js: 707.84 KB -> 700.73 KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Asana: https://app.asana.com/1/137249556945/project/1198964220583541/task/1210068517547285?focus=true
Description
POC for removing Catalina support
Steps to test