small fixes #23
Open
small fixes #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR contains small fixes focused on improving SQL query patterns and event handling configuration. The changes replace inefficient query result scanning with direct table references and enhance retry configuration for event processing.
Key Changes:
- Replaced
result_scan(last_query_id())with parameterized table references ($1) in SQL procedures - Added event payload limits and configurable retry behavior for HTTP status codes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dtagent/plugins/resource_monitors.sql/060_p_refresh_resource_monitors.sql | Replaced result_scan(last_query_id()) calls with $1 parameter reference for improved query efficiency |
| src/dtagent.conf/otel-config.json | Added payload size limits, event count limits, and retry status codes configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.