-
Notifications
You must be signed in to change notification settings - Fork 33
feat(openpipeline-v2): add pipeline group resources #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c821281 to
4ac9dfe
Compare
64a6213 to
b1e2363
Compare
b1e2363 to
3188a79
Compare
6e1c057 to
49a54f8
Compare
3188a79 to
0617b1c
Compare
This adds the pipeline-group resources for every openpipeline_v2 kind
This adds the pipeline groups to the provider and comments it out
0617b1c to
1a91df1
Compare
|
| } | ||
| }, | ||
| "version": "1.21" | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line missing at the end of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say this is not really needed for JSON files (there won't be any additions below the object, as this would also lead to an invalid syntax), and because they're generated, I would prefer to either adjust it in the generator or leave it as it currently is :)



Why this PR?
To support the upcoming openpipeline pipeline-groups schema
What has changed?
New pipeline-groups resources added for each kind
How does it do it?
Generating via schema
How is it tested?
Manual tests with one example locally. Tests will follow with E2E after this one is merged
How does it affect users?
It doesn't affect users at the moment, as it's not wired up yet. Still, once it is available, they will be able to use the pipeline-groups feature.
Issue: CA-16606