Skip to content

Conversation

@Kirdock
Copy link
Collaborator

@Kirdock Kirdock commented Oct 14, 2025

Why this PR?

To support the upcoming openpipeline pipeline-groups schema

What has changed?

New pipeline-groups resources added for each kind

How does it do it?

Generating via schema

How is it tested?

Manual tests with one example locally. Tests will follow with E2E after this one is merged

How does it affect users?

It doesn't affect users at the moment, as it's not wired up yet. Still, once it is available, they will be able to use the pipeline-groups feature.

Issue: CA-16606

@Kirdock Kirdock force-pushed the fix/openpipeline-v2/enum-values branch 2 times, most recently from c821281 to 4ac9dfe Compare October 15, 2025 07:11
@Kirdock Kirdock force-pushed the feat/openpipeline-add-pipeline-groups branch from 64a6213 to b1e2363 Compare October 15, 2025 08:06
@Kirdock Kirdock changed the base branch from fix/openpipeline-v2/enum-values to main October 15, 2025 08:06
@Kirdock Kirdock marked this pull request as ready for review October 15, 2025 08:07
@Kirdock Kirdock force-pushed the feat/openpipeline-add-pipeline-groups branch from b1e2363 to 3188a79 Compare October 17, 2025 11:27
@Kirdock Kirdock changed the base branch from main to feat/allow-feature-flags October 17, 2025 11:27
d0weinberger
d0weinberger previously approved these changes Oct 22, 2025
@Kirdock Kirdock force-pushed the feat/allow-feature-flags branch 6 times, most recently from 6e1c057 to 49a54f8 Compare October 24, 2025 09:39
@Kirdock Kirdock force-pushed the feat/openpipeline-add-pipeline-groups branch from 3188a79 to 0617b1c Compare October 27, 2025 15:09
@Kirdock Kirdock changed the base branch from feat/allow-feature-flags to main October 27, 2025 15:09
@Kirdock Kirdock dismissed d0weinberger’s stale review October 27, 2025 15:09

The base branch was changed.

This adds the pipeline-group resources for every openpipeline_v2 kind
This adds the pipeline groups to the provider and comments it out
@Kirdock Kirdock force-pushed the feat/openpipeline-add-pipeline-groups branch from 0617b1c to 1a91df1 Compare October 27, 2025 16:08
@sonarqubecloud
Copy link

}
},
"version": "1.21"
} No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line missing at the end of file

Copy link
Collaborator Author

@Kirdock Kirdock Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is not really needed for JSON files (there won't be any additions below the object, as this would also lead to an invalid syntax), and because they're generated, I would prefer to either adjust it in the generator or leave it as it currently is :)

@Kirdock Kirdock marked this pull request as draft October 31, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants